Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fieldName path params for Case Classification valueCount and documentCount #823

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: fieldName path params for Case Classification valueCount and documentCount #823

merged 1 commit into from
May 24, 2024

Conversation

paulgerold
Copy link
Contributor

@paulgerold paulgerold commented May 24, 2024 •
edited
Loading

Both calls valueCount and documentCount take fieldName parameters

These calls are not yet used on admin-ui

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@paulgerold paulgerold marked this pull request as ready for review May 24, 2024 14:46
@paulgerold paulgerold requested a review from a team May 24, 2024 14:46
@paulgerold paulgerold requested a review from a team as a code owner May 24, 2024 14:46
@paulgerold paulgerold changed the title fix: fieldName path params fix: fieldName path params for Case Classification valueCount and documentCount May 24, 2024
@paulgerold paulgerold force-pushed the MLX-1227-fix-field-name-params-in branch from a25909f to 54ad10d Compare May 24, 2024 15:12
@paulgerold paulgerold enabled auto-merge May 24, 2024 15:12
@paulgerold paulgerold added this pull request to the merge queue May 24, 2024
Merged via the queue into master with commit cc2f4d5 May 24, 2024
5 checks passed
@paulgerold paulgerold deleted the MLX-1227-fix-field-name-params-in branch May 24, 2024 15:16
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 54.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lprovost-coveo lprovost-coveo lprovost-coveo approved these changes

@toofff toofff toofff approved these changes

@aboissinot-coveo aboissinot-coveo Awaiting requested review from aboissinot-coveo

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgerold @toofff @lprovost-coveo