Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sfint 4378 added a tooltip to show origin1 on clickedDocList and queriesList #103

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

erocheleau
Copy link
Collaborator

image
image

Added a tooltip to documents and queries
Added tests for the tooltips
Actually test the hover
Fix build
Copy link

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice, the position of the triangle is so natural 👌

src/components/UserActions/QueryList.ts Show resolved Hide resolved
src/components/UserActions/UserActions.scss Show resolved Hide resolved
if (insertBeforeElement) {
const tooltip = document.createElement('div');
tooltip.classList.add('coveo-tooltip-origin1');
tooltip.innerText = action.raw.origin_level_1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it would be clear to agents that the tooltip content is the origin level 1? I think it depends a lot on whether the origin level 1 value is meaningful.

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the mockup for that, but I think the original logic is that agents don't know more what a "search hub" or a "origin" is really, so this is more or less debug info for the educated and these people would know what this value is.

I could be mis-remembering the reasoning though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...so this is more or less debug info for the educated and these people would know what this value is

I'm not sure using a tooltip to display this information is the best choice then. My understanding is that the tooltip will be confusing for a majority of agents. To be honest, I think it will add noise for most of them.

@adroletCoveo Instead of using a tooltip, what would you think of adding an "information" icon or something that the agent could click to reveal a popup with the details? It would give some more space to indicate what this value is. More troubleshooting values could be added in the future.

Another possibility could be to have some kind of switch to enable this kind of troubleshooting information, so agents are not confused with it, and others can still access it quickly.

Any thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with these suggestions, but I would advocate they are definitely out of scope for this feature that was already planned and designed.

Perhaps in the Quantic version?

Copy link

@adroletCoveo adroletCoveo Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point @lbergeron I agree that the tooltips add noise. You have good suggestions, my only concern with the information icon is that repeating it might also add noise. The switch idea could be nice, since it's useful to only a few. I'll investigate it for the Quantic version.

For this version I'll check with Antoine since he's the one who worked on the Lightning improvements, maybe the trade-off noise/usefulness is not worth it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention for documenting purposes, after speaking with Étienne this morning, Antoine and I think it would be better not to show the tooltip. We believe so because so far we haven't found the reason why it was needed in the first place. However it is not a terrible experience for the user and could be left as is. (but we prefer not to ;) )

We agreed with Étienne to follow what PMs prefer depending on the need vs time required.
But I will think about this issue for the Quantic version of the Insight panel.

@erocheleau erocheleau merged commit 5aee218 into master Feb 2, 2022
erocheleau added a commit that referenced this pull request Feb 2, 2022
erocheleau added a commit that referenced this pull request Feb 3, 2022
PR comments fix for #103 
(Missed one commit before merging #103 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants