fix(SFINT-2502): Allow the use of result from the constructor #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow and prioritize the use of result from the constructor Add precondition in the constructor to ensure the presence of a result, resolved or provided.
louis-bompart
requested review from
jeremierobert-coveo,
mikegron and
tedre191
mikegron
approved these changes
Aug 26, 2019
jeremierobert-coveo
approved these changes
Aug 26, 2019
tedre191
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow and prioritize the use of result from the constructor
Add precondition in the constructor to ensure the presence of a result, resolved or provided.
I chose to throw if no result is provided because that means they're an issue with the customization (e.g. trying to use a result component outside of a result template)