SFINT-3521: Added AugmentedResultList #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanlb
requested review from
mikegron,
lbergeron,
louis-bompart and
jeremierobert-coveo
louis-bompart
requested changes
Nov 16, 2020
jeremierobert-coveo
requested changes
Nov 16, 2020
nathanlb
changed the title
nathanlb
changed the title
jeremierobert-coveo
requested changes
Nov 17, 2020
Co-authored-by: Jeremie Robert <43446516+jeremierobert-coveo@users.noreply.github.com>
jpmarceau
reviewed
Nov 17, 2020
jeremierobert-coveo
approved these changes
Nov 17, 2020
lbergeron
reviewed
Nov 17, 2020
I think you're correct that the specific data should take precedence. |
lbergeron
approved these changes
Nov 17, 2020
tests/components/AugmentedResultList/AugmentedResultList.spec.ts
Outdated
Show resolved
Hide resolved
louis-bompart
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
LGTM, RIP Lazy, except if @mikegron sees an inconvenience with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is meant to allow devs to augment their coveo results with external data before render.