DOC-458 Icon documentation revision #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbeaudoincoveo
commented
Feb 13, 2017
fbeaudoincoveo
commented
fbeaudoincoveo
commented
Feb 13, 2017
| */ | ||
| value: ComponentOptions.buildIconOption(), | ||
|
|
||
| /** | ||
| * Specifies whether the Icon component should output the smaller version of the icon instead of of the regular one. | ||
| * Specifies whether the Icon component should output the smaller version of the icon instead of the regular one. | ||
| * | ||
| * Default value is `false`. | ||
| */ | ||
| small: ComponentOptions.buildBooleanOption(), |
There was a problem hiding this comment.
Should I add defaultValue: false here?
There was a problem hiding this comment.
No. We should remove the misleading comment though.
Default value is undefined
olamothe
requested changes
Feb 15, 2017
| */ | ||
| value: ComponentOptions.buildIconOption(), | ||
|
|
||
| /** | ||
| * Specifies whether the Icon component should output the smaller version of the icon instead of of the regular one. | ||
| * Specifies whether the Icon component should output the smaller version of the icon instead of the regular one. | ||
| * | ||
| * Default value is `false`. | ||
| */ | ||
| small: ComponentOptions.buildBooleanOption(), |
There was a problem hiding this comment.
No. We should remove the misleading comment though.
Default value is undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.