-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-458 Icon documentation revision #353
Conversation
fbeaudoincoveo
commented
Feb 13, 2017
*/ | ||
value: ComponentOptions.buildIconOption(), | ||
|
||
/** | ||
* Specifies whether the Icon component should output the smaller version of the icon instead of of the regular one. | ||
* Specifies whether the Icon component should output the smaller version of the icon instead of the regular one. | ||
* | ||
* Default value is `false`. | ||
*/ | ||
small: ComponentOptions.buildBooleanOption(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add defaultValue: false
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. We should remove the misleading comment though.
Default value is undefined
*/ | ||
value: ComponentOptions.buildIconOption(), | ||
|
||
/** | ||
* Specifies whether the Icon component should output the smaller version of the icon instead of of the regular one. | ||
* Specifies whether the Icon component should output the smaller version of the icon instead of the regular one. | ||
* | ||
* Default value is `false`. | ||
*/ | ||
small: ComponentOptions.buildBooleanOption(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. We should remove the misleading comment though.
Default value is undefined