Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(commerce): add tests for atomic-commerce-text #4061

Merged
merged 6 commits into from
Jul 24, 2024
Merged

test(commerce): add tests for atomic-commerce-text #4061

merged 6 commits into from
Jul 24, 2024

Conversation

Spuffynism
Copy link
Contributor

@Spuffynism Spuffynism commented Jun 6, 2024 •
edited by alexprudhomme
Loading

TODO:

  • Test for pluralization

https://coveord.atlassian.net/browse/KIT-3255

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 6, 2024 •
edited by github-actions bot
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 245.1 245.1 0
commerce 341.6 341.6 0
search 414 414 0
insight 392.4 392.4 0
product-listing 307.1 307.1 0
product-recommendation 211.4 211.4 0
recommendation 258.2 258.2 0
ssr 405.4 405.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme self-assigned this Jul 23, 2024
@alexprudhomme alexprudhomme changed the title feat(commerce): test atomic-commerce-text test(commerce): test atomic-commerce-text Jul 23, 2024
@alexprudhomme alexprudhomme marked this pull request as ready for review July 23, 2024 20:51
@alexprudhomme alexprudhomme requested a review from a team as a code owner July 23, 2024 20:51
@alexprudhomme alexprudhomme changed the title test(commerce): test atomic-commerce-text test(commerce): add tests for atomic-commerce-text Jul 23, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit 7aa3e8e Jul 24, 2024
105 of 111 checks passed
@alexprudhomme alexprudhomme deleted the feat-kit-3255-test-atomic-commerce-text branch July 24, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart louis-bompart approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme alexprudhomme is a code owner automatically assigned from coveo/search

Assignees

@alexprudhomme alexprudhomme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spuffynism @louis-bompart @alexprudhomme