Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genqa): new feedback modal #4092

Merged
merged 11 commits into from
Jul 12, 2024
Merged

feat(genqa): new feedback modal #4092

merged 11 commits into from
Jul 12, 2024

Conversation

jelmedini
Copy link
Contributor

@jelmedini jelmedini commented Jun 13, 2024

Feedback Modal Full width

Screenshot 2024-06-14 at 3 24 25 PM

Hover buttons state

Screenshot 2024-06-14 at 3 27 25 PM

Selected buttons state

Screenshot 2024-06-14 at 3 27 36 PM

Required field error after submit state

Screenshot 2024-06-14 at 3 27 50 PM

Feedback modal mobile version

Screenshot 2024-06-14 at 3 28 12 PM

Feedback modal mobile version with error

Screenshot 2024-07-11 at 11 21 00 AM

Sumbit Events

Screenshot 2024-07-05 at 10 39 36 AM

DEMO

Screen.Recording.2024-06-14.at.3.23.29.PM.mov

SVCC-3815

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 13, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.9 244.9 0
commerce 339.5 339.5 0
search 411.8 411.8 0
insight 391.9 391.9 0
product-listing 306.6 306.6 0
product-recommendation 211.2 211.2 0
recommendation 258 258 0
ssr 404.3 404.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@jelmedini jelmedini marked this pull request as draft July 8, 2024 15:24
@jelmedini jelmedini added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit 7bf9bfe Jul 12, 2024
91 of 92 checks passed
@jelmedini jelmedini deleted the feature/SVCC-3815 branch July 12, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants