Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(atomic): add query-summary E2E tests #4102

Merged
merged 11 commits into from
Jun 26, 2024
Merged

fix(atomic): add query-summary E2E tests #4102

merged 11 commits into from
Jun 26, 2024

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar requested a review from a team as a code owner June 18, 2024 14:54
@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 18, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.9 204.9 0
commerce 293.1 293.1 0
search 372.4 372.4 0
insight 352.4 352.4 0
product-listing 267 267 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.2 365.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@y-lakhdar y-lakhdar enabled auto-merge June 25, 2024 14:17
louis-bompart
louis-bompart approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minus the todo I marked

@y-lakhdar y-lakhdar added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 6f73da7 Jun 26, 2024
87 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3254 branch June 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe olamothe approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-lakhdar @olamothe @louis-bompart