Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): adjust product-list placeholder #4108

Merged
merged 4 commits into from
Jun 26, 2024
Merged

fix(atomic): adjust product-list placeholder #4108

merged 4 commits into from
Jun 26, 2024

Conversation

y-lakhdar
Copy link
Contributor

  • Add ItemListGuard to prevent the placeholders to be displayed in case no results is returned on the initial page load
  • Added the minimum E2E tests to cover the bug fix

https://coveord.atlassian.net/browse/KIT-3329

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 20, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.9 204.9 0
commerce 293.1 293.1 0
search 372.4 372.4 0
insight 352.4 352.4 0
product-listing 267 267 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.2 365.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but unsure about how you "get" the summary state

Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, apart from summaryState() not being reactive, as pointed out by Louis

@y-lakhdar y-lakhdar added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 9b28869 Jun 26, 2024
86 of 87 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3329 branch June 26, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants