This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Generate -SNAPSHOT dependencies for maven source #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some error logging.
|
test |
dreisch-coveo
approved these changes
May 29, 2018
|
I understand the issue, but relying on SNAPSHOT should be a last resort. Lure should support it, but you should change your process if something relies consistently on snapshots. |
fredboutin
reviewed
May 29, 2018
| @@ -17,14 +17,22 @@ import ( | |||
| ) | |||
|
|
|||
| func mvnOutdated(path string) []moduleVersion { | |||
|
|
|||
|
After discussion with @fredboutin, I'll remove the mvn install. It should not be done by Lure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for maven source that are relying on -SNAPSHOT version. When running
versions:display-dependency-updates, if the plugin cannot resolve the dependencie it fails. If the dependency are -SNAPSHOT version, they normally won't be available on the remote server (they normally are sitting in your local m2 cache). As a solution we will now force the generation of the local -SNAPSHOT dependency version before running the plugin.This pullrequest also adds some error logging.