Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with fix #100

Merged
merged 1 commit into from
May 17, 2018
Merged

Update readme with fix #100

merged 1 commit into from
May 17, 2018

Conversation

coenm
Copy link
Contributor

@coenm coenm commented May 17, 2018

Update README with additional information how to use multiple expressions.

According to dotnet/msbuild#2999 (comment) you'll have to escape the surrounding quotes in a parameter with a comma.

This has been described in the readme.

An other fix would be to have an other sperator. I.e. a space (like opencover).

@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #100 into master will decrease coverage by 12.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #100       +/-   ##
===========================================
- Coverage   98.91%   86.57%   -12.34%     
===========================================
  Files          15       15               
  Lines        1378     1378               
===========================================
- Hits         1363     1193      -170     
- Misses         15      185      +170
Impacted Files Coverage Δ
src/coverlet.core/Coverage.cs 14.13% <0%> (-85.87%) ⬇️
src/coverlet.core/Helpers/InstrumentationHelper.cs 91.32% <0%> (-6.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97bfb3...a244815. Read the comment docs.

@tonerdo tonerdo merged commit 212b1f4 into coverlet-coverage:master May 17, 2018
@coenm coenm deleted the bugfix/cant-parse-properties-with-commas branch May 18, 2018 11:34
NorekZ pushed a commit to NorekZ/coverlet that referenced this pull request Nov 8, 2018
…-properties-with-commas

Update readme with fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants