This repository has been archived by the owner on May 30, 2021. It is now read-only.
VA, AR, and NY Boroughs Scraper #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add NH, USA * Add JSDocs * fix: CT, USA * fix: add check for 404 * fix: CT, USA
lazd
reviewed
Mar 23, 2020
| @@ -8,7 +8,7 @@ const noScrapersTest = () => test('no scrapers modified', () => console.log('No | |||
|
|
|||
| describe('scrappers', () => { | |||
| beforeAll(() => { | |||
| jest.setTimeout(30000); | |||
There was a problem hiding this comment.
That's a big number! But if it makes tests run... @qgolsteyn @camjc?
lazd
reviewed
Mar 23, 2020
lazd
reviewed
Mar 23, 2020
lazd
reviewed
Mar 23, 2020
lazd
reviewed
Mar 23, 2020
Co-Authored-By: Larry Davis <lazdnet@gmail.com>
lazd
reviewed
Mar 23, 2020
|
The scraper test which keeps failing works on my computer. Virginia timing out is what's causing the problem. |
chunder
approved these changes
Mar 24, 2020
|
Nice work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scraper.tests.js was changed because the VA scraper times out because downloading all the PDFs takes ~200 seconds.