Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twap test structure #154

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Twap test structure #154

merged 7 commits into from
Aug 30, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Aug 30, 2023

This PR just restructures the tests.

In my opinion, tests should assert one thing. This will make it easier to understand the scope, maintain, and know exactly what is wrong when tests start to fail.

For this reason, I reorganized the tests (in anticipation to the fact I want to create a new PR with new tests)

Conditional Order

image

Twap

image

@anxolin anxolin requested review from mfw78 and a team August 30, 2023 11:05
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@coveralls
Copy link
Collaborator

coveralls commented Aug 30, 2023

Coverage Status

coverage: 72.617%. remained the same when pulling 0831e0d on twap-test-structure into 3a61922 on main.

@anxolin anxolin changed the base branch from main to smarter-twap-indexing August 30, 2023 11:23
src/composable/ConditionalOrder.spec.ts Outdated Show resolved Hide resolved
src/composable/orderTypes/Twap.spec.ts Outdated Show resolved Hide resolved
src/composable/orderTypes/Twap.spec.ts Show resolved Hide resolved
src/composable/orderTypes/Twap.spec.ts Outdated Show resolved Hide resolved
src/composable/orderTypes/Twap.spec.ts Outdated Show resolved Hide resolved
@anxolin anxolin changed the base branch from smarter-twap-indexing to main August 30, 2023 17:31
@anxolin
Copy link
Contributor Author

anxolin commented Aug 30, 2023

Addressed the comments and low risk PR (also test pass)

I will merge to not waterfall too much

@anxolin anxolin merged commit ef5bbf9 into main Aug 30, 2023
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@alfetopito alfetopito deleted the twap-test-structure branch August 31, 2023 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants