-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twap test structure #154
Twap test structure #154
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
9f59dde
to
4a11e0f
Compare
ca1c761
to
f813c55
Compare
fcc1ea7
to
0831e0d
Compare
Addressed the comments and low risk PR (also test pass) I will merge to not waterfall too much |
This PR just restructures the tests.
In my opinion, tests should assert one thing. This will make it easier to understand the scope, maintain, and know exactly what is wrong when tests start to fail.
For this reason, I reorganized the tests (in anticipation to the fact I want to create a new PR with new tests)
Conditional Order
Twap