feat!: remove goerli #199
Merged
feat!: remove goerli #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
commented
Jan 29, 2024
| @@ -44,7 +44,7 @@ const orderSigningUtils = new OrderSigningUtils() | |||
| ### Sign, fetch, post and cancel order | |||
|
|
|||
| For clarity, let's look at the use of the API with a practical example: | |||
| Exchanging `0.4 GNO` to `WETH` on `Goerli` network. | |||
| Exchanging `0.4 GNO` to `WETH` on `Gnosis chain` network. | |||
There was a problem hiding this comment.
Migrated examples to Gnosis chain for future proofing.
Sepolia will eventually die and we'll have to do this all over again.
It was the same with Rinkeby before Goerli.
| @@ -4,7 +4,6 @@ | |||
| */ | |||
| export enum SupportedChainId { | |||
| MAINNET = 1, | |||
| GOERLI = 5, | |||
There was a problem hiding this comment.
That's the main change
alfetopito
commented
Jan 30, 2024
Comment on lines
+13
to
+15
| export const ALL_SUPPORTED_CHAIN_IDS: SupportedChainId[] = Object.values(SupportedChainId).filter( | ||
| (chainId) => typeof chainId === 'number' | ||
| ) as SupportedChainId[] |
There was a problem hiding this comment.
Dynamically generated so this is one less thing to update when new chains are added/removed
alfetopito
force-pushed
the
remove-goerli
branch
from
0a0c22e
to
16c2655
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove Goerli from supported networks
Testing