Fix solver competition loading for multiple winners #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
added
the
E:6.2 Time to Happy Moo
squadgazzz
approved these changes
Oct 10, 2024
Comment on lines
+62
to
+72
| WITH competition AS ( | ||
| SELECT sc.id | ||
| FROM solver_competitions sc | ||
| JOIN settlements s ON sc.id = s.auction_id | ||
| WHERE s.tx_hash = $1 | ||
| ) | ||
| SELECT sc.json, sc.id, COALESCE(ARRAY_AGG(s.tx_hash) FILTER (WHERE s.tx_hash IS NOT NULL), '{}') AS tx_hashes | ||
| FROM solver_competitions sc | ||
| JOIN settlements s ON sc.id = s.auction_id | ||
| WHERE s.tx_hash = $1 | ||
| WHERE sc.id = (SELECT id FROM competition) | ||
| GROUP BY sc.id |
There was a problem hiding this comment.
Initially, I thought the query could be simplified, but it looks like this is not the case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A breaking change of SolverCompetitionAPI, which now potentially returns more than 1 transaction associated with the competition (will notify all teams on slack soon).
Resolves one of the points from #2830 (comment)
Changes
Vec<TransactionHash>, instead ofOption<TransactionHash>How to test
Refactored unit test to prove it works and that no regression issues were introduced.
Existing e2e test for solver competition proves that competition is properly returned.