Fix integration raft_uv_transport test failures
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
For consistency with other callback names in uv_tcp_connect.c Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Since we're currently only supporting IPv4 and since we're setting ai_family to AF_INET, the AI_ADDRCONFIG flag is not really making any difference as getaddrinfo returns only IPv4 addresses. This makes the test suite pass also if there isn't a non-loopback network interface on the system configured with IPv4. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Call RaftHeapFree(r->handshake.base) only if there was a successful call to uvTcpEncodeHandshake(). Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 73.97% 74.01% +0.03%
==========================================
Files 53 53
Lines 9454 9455 +1
Branches 2337 2337
==========================================
+ Hits 6994 6998 +4
+ Misses 1131 1130 -1
+ Partials 1329 1327 -2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests where failing when running them on a system without a non-loopback network interface configured with IPv4.