Skip to content

Commit

Permalink
[cm] - Added . in messages in order to be consistent with others
Browse files Browse the repository at this point in the history
  • Loading branch information
azlancpool committed Mar 11, 2021
1 parent e67470e commit 8c3474e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions gui/muc_notification_messages.go
Expand Up @@ -101,7 +101,7 @@ type updateFailureMessages struct {

func getAffiliationUpdateFailureMessage(nickname string, newAffiliation data.Affiliation, err error) *updateFailureMessages {
return &updateFailureMessages{
notificationMessage: i18n.Localf("The position of %s couldn't be changed", nickname),
notificationMessage: i18n.Localf("The position of %s couldn't be changed.", nickname),
errorDialogTitle: i18n.Local("Changing the position failed"),
errorDialogHeader: i18n.Localf("The position of %s couldn't be changed", nickname),
errorDialogMessage: getAffiliationFailureErrorMessage(nickname, newAffiliation, err),
Expand Down Expand Up @@ -133,7 +133,7 @@ func getRoleUpdateFailureMessage(nickname string, newRole data.Role) *updateFail
}

return &updateFailureMessages{
notificationMessage: i18n.Localf("The role of %s couldn't be changed", nickname),
notificationMessage: i18n.Localf("The role of %s couldn't be changed.", nickname),
errorDialogTitle: i18n.Local("Changing the role failed"),
errorDialogHeader: i18n.Localf("The role of %s couldn't be changed", nickname),
errorDialogMessage: getUpdateRoleFailureErrorMessage(nickname, newRole),
Expand Down Expand Up @@ -195,7 +195,7 @@ func getMUCNotificationMessageFrom(d interface{}) string {
case data.AffiliationRoleUpdate:
return getAffiliationRoleUpdateMessage(t)
}
panic(fmt.Sprintf("unkown update type: %T", d))
panic(fmt.Sprintf("unkown update type: %v", d))

This comment has been minimized.

Copy link
@azlancpool

azlancpool Mar 11, 2021

Author Contributor

It solves comments on #628, #644, #648, #651, #633 and #637

}

func getAffiliationUpdateMessage(affiliationUpdate data.AffiliationUpdate) string {
Expand Down
2 changes: 1 addition & 1 deletion gui/muc_room.go
Expand Up @@ -443,7 +443,7 @@ func (v *roomView) tryKickOccupant(occupant *muc.Occupant, reason string) {
func (v *roomView) onKickOccupantSuccess(occupantNickname string) {
doInUIThread(func() {
v.loadingViewOverlay.hide()
v.notifications.info(i18n.Localf("%s was temporarily removed from the room", occupantNickname))
v.notifications.info(i18n.Localf("%s was temporarily removed from the room.", occupantNickname))
v.roster.hideRosterInfoPanel()
})
}
Expand Down

3 comments on commit 8c3474e

@olabiniV2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, OK.

@sacurio
Copy link
Contributor

@sacurio sacurio commented on 8c3474e Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of #607

@azlancpool
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of #611 and #615

Please sign in to comment.