Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be notified when you are removed as member (9.4) #628

Closed
Cris2760 opened this issue Jul 20, 2020 · 11 comments
Closed

Be notified when you are removed as member (9.4) #628

Cris2760 opened this issue Jul 20, 2020 · 11 comments
Labels
Estimate - small MUC - Admin Capabilities Functionality MUC Admin Capabilities Functionality MUC Priority: Soon State: Done This store is done - usually that means that the story should be closed.
Milestone
0.4 Release

Comments

@Cris2760
Copy link

Cris2760 commented Jul 20, 2020 •
edited by olabiniV2

An administrator can change the affiliation of a user from member to "none". When this happens to you, you should be notified of it. Since this can happen both when you are inside a room, or when you are outside the room and don't have it open, this story involves the notification happening in both these cases. When not in the room, a standalone notification should be displayed, while when you're in the room, you will have the same behavior as in #671, except that the notification should say who removed you from the room, and an optional reason.

Note: Please see the reference on https://xmpp.org/extensions/xep-0045.html
@Cris2760 Cris2760 added the MUC label Jul 20, 2020
@rmendoza83 rmendoza83 added the MUC - Admin Capabilities Functionality MUC Admin Capabilities Functionality label Jul 20, 2020
@olabiniV2
Copy link
Contributor

This is part of #271.

@Cris2760 Cris2760 added this to the 0.4 Release milestone Jan 19, 2021
@azlancpool azlancpool added the State: Doing This story is currently in development label Feb 17, 2021
azlancpool referenced this issue Feb 17, 2021
@azlancpool
[cp] #632 - Publishes events that indicates updating the affiliation …
ee34f6a 
…and role of the occupant
azlancpool referenced this issue Feb 17, 2021
@pedropalau
[ps] #650 - Updates affiliation update related events to use the full…
898e82e 
… affiliation update data
azlancpool referenced this issue Feb 17, 2021
@pedropalau
[ps] #650 room-events - Updates affiliation update related events to …
c861af9 
…be simple and to use the full affiliation update data from session
azlancpool referenced this issue Feb 17, 2021
@pedropalau
[mp] #632 - Do a refactor to improve the affiliations and roles funct…
89c2061 
…ionalities organization
@azlancpool azlancpool added in-user-test This story is currently in State: test and should have user testing done State: Test This story is in testing, either code review or user testing or both State: Doing This story is currently in development and removed State: Doing This story is currently in development State: Test This story is in testing, either code review or user testing or both in-user-test This story is currently in State: test and should have user testing done labels Feb 17, 2021
sacurio added a commit that referenced this issue Feb 18, 2021
@sacurio
[cs] #628 - Improves the message when an occupant has been removed as…
b4c3de6 
… a member
pedropalau added a commit that referenced this issue Feb 22, 2021
@pedropalau
[cp] #632, #628, #644, #624 - Implements a functionality that returs …
09e56b7 
…a specific message for affiliation, role or affiliation-role update.

Related to 89c2061#commitcomment-47313779
azlancpool added a commit that referenced this issue Feb 22, 2021
@azlancpool
[cp] #632, #628, #644, #624 - Replaces functionality that returns a m…
2084a00 
…essage when an occupant affiliation has been changed
azlancpool added a commit that referenced this issue Feb 22, 2021
@azlancpool
[cp] #632, #628, #644, #624 - Adds functionality that returns a messa…
0fadd47 
…ge when an occupant role has been changed
azlancpool added a commit that referenced this issue Feb 22, 2021
@azlancpool
[cp] #632, #628, #644, #624 - Replaces old functionality that shows a…
e4ec729 
… message when an occupant role has been changed
pedropalau added a commit that referenced this issue Feb 23, 2021
@pedropalau
[ps] #632, #628, #644, #624 - Adds the functionality to get the messa…
b792a15 
…ge for an affiliation-role update
pedropalau added a commit that referenced this issue Feb 23, 2021
@pedropalau
[ps] #632, #628, #644, #624 - Uses the test helper to create an affil…
f878760 
…iation from string (only for test purposes)
pedropalau added a commit that referenced this issue Feb 23, 2021
@pedropalau
[ps] #632, #628, #644, #624 - Updates the messages for the unexpected…
6df443f 
… situation of affiliation-role update
pedropalau added a commit that referenced this issue Feb 23, 2021
@pedropalau
[ps] #632, #628, #644, #624 - Use a more neutral language for relatin…
d63d8b0 
…g to the role update
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Removes default statement
2a5ec52
@azlancpool
Copy link
Contributor

Comments was fixed, it's ready to be reviewed by @olabiniV2

@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Mar 10, 2021
@olabiniV2
Copy link
Contributor

Things to fix.

@olabiniV2 olabiniV2 reopened this Mar 10, 2021
@olabiniV2 olabiniV2 added State: Doing This story is currently in development and removed State: Test This story is in testing, either code review or user testing or both in-code-review This story is currently in state: test and should have code review done labels Mar 10, 2021
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Adds information about unkn…
c9bf972 
…own type in `getMUCNotificationMessageFrom`
@azlancpool
Copy link
Contributor

It's ready to be reviewed by @olabiniV2

@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Mar 10, 2021
@olabiniV2
Copy link
Contributor

Still things to fix.

@olabiniV2 olabiniV2 added State: Doing This story is currently in development and removed State: Test This story is in testing, either code review or user testing or both in-code-review This story is currently in state: test and should have code review done labels Mar 11, 2021
azlancpool referenced this issue Mar 11, 2021
@azlancpool
[cm] - Added . in messages in order to be consistent with others
8c3474e
@azlancpool
Copy link
Contributor

It's ready to be reviewed by @olabiniV2

@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Mar 12, 2021
@olabiniV2
Copy link
Contributor

OK

@olabiniV2 olabiniV2 removed the in-code-review This story is currently in state: test and should have code review done label Mar 12, 2021
@pedropalau pedropalau added State: Done This store is done - usually that means that the story should be closed. and removed State: Test This story is in testing, either code review or user testing or both labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimate - small MUC - Admin Capabilities Functionality MUC Admin Capabilities Functionality MUC Priority: Soon State: Done This store is done - usually that means that the story should be closed.
Projects
None yet
Milestone
0.4 Release
Development

No branches or pull requests
5 participants
@pedropalau @azlancpool @rmendoza83 @Cris2760 @olabiniV2