Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be notified when you get to be a moderator (9.6) #633

Closed
Cris2760 opened this issue Jul 20, 2020 · 8 comments
Closed

Be notified when you get to be a moderator (9.6) #633

Cris2760 opened this issue Jul 20, 2020 · 8 comments
Labels
Estimate - small MUC - Admin Capabilities Functionality MUC Admin Capabilities Functionality MUC Priority: Now State: Done This store is done - usually that means that the story should be closed.
Milestone
0.4 Release

Comments

@Cris2760
Copy link

Cris2760 commented Jul 20, 2020 •
edited by olabiniV2

When a moderator changes the role of an occupant to be a moderator, the user should be notified of this. Since this is something that only can happen when you're inside a room, the notification should happen somewhere in the room view, but I'm not sure if it makes sense to put it in the conversation view, or outside.

The notification should show who changed the status, what the reason was, and also what your new role in the room is.

Note: Please see the reference on https://xmpp.org/extensions/xep-0045.html
@Cris2760 Cris2760 added the MUC label Jul 20, 2020
@rmendoza83 rmendoza83 added the MUC - Admin Capabilities Functionality MUC Admin Capabilities Functionality label Jul 20, 2020
@olabiniV2
Copy link
Contributor

This is part of #271.

@Cris2760 Cris2760 added Priority: Now State: Ready This story is ready for development and removed Priority: Soon labels Jan 4, 2021
@Cris2760 Cris2760 added this to the 0.4 Release milestone Jan 19, 2021
@azlancpool azlancpool added State: Doing This story is currently in development and removed State: Ready This story is ready for development labels Feb 17, 2021
azlancpool referenced this issue Feb 17, 2021
@MauroVelasco
[cm] #637 - Returns appropiate message for self role change event
ae60792
azlancpool referenced this issue Feb 17, 2021
@MauroVelasco
[cm] #637 - Handles self occupant role update event in the GUI package
a8b0a38
@azlancpool azlancpool added in-user-test This story is currently in State: test and should have user testing done State: Test This story is in testing, either code review or user testing or both State: Doing This story is currently in development and removed State: Doing This story is currently in development State: Test This story is in testing, either code review or user testing or both in-user-test This story is currently in State: test and should have user testing done labels Feb 17, 2021
MauroVelasco added a commit that referenced this issue Feb 25, 2021
@MauroVelasco
[ms] #624, #628, #633, #637, #644, #648, #651 - Use of `selfOccupantR…
4a37e23 
…oleUpdate` instead of `roleUpdate` structure
MauroVelasco added a commit that referenced this issue Feb 25, 2021
@MauroVelasco
[ms] #624, #628, #633, #637, #644, #648, #651 - Uses of `SelfRoleUpda…
5d739dd 
…te `instead of `RoleUpdate `
MauroVelasco added a commit that referenced this issue Feb 25, 2021
@MauroVelasco
[ms] #624, #628, #633, #637, #644, #648, #651 - Generates a message f…
98be14f 
…or self role update
MauroVelasco added a commit that referenced this issue Feb 25, 2021
@MauroVelasco
[ms] #624, #628, #633, #637, #644, #648, #651 - Drops unused function…
8c116bb 
…s and refactor them
sacurio added a commit that referenced this issue Feb 26, 2021
@sacurio
[ps] #624, #628, #633, #637, #644, #648, #651 - Adds a structure that…
35898a8 
… contains the information about the updated affiliation/role of the self occupant
sacurio added a commit that referenced this issue Feb 26, 2021
@sacurio
[ps] #624, #628, #633, #637, #644, #648, #651 - Modifies the event of…
71cfea8 
… the updated affiliation/role of the self occupant
sacurio added a commit that referenced this issue Feb 26, 2021
@sacurio
[ps] #624, #628, #633, #637, #644, #648, #651 - Receives the event in…
7d8a647 
… the UI for the affiliation/role udpate of the self occupant
@olabiniV2
Copy link
Contributor

Things to fix.

@olabiniV2 olabiniV2 added State: Doing This story is currently in development and removed State: Test This story is in testing, either code review or user testing or both in-code-review This story is currently in state: test and should have code review done labels Mar 10, 2021
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Uses panic instead of retur…
db3be77 
…ns a unfriendly message
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Removes default statement
2a5ec52
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Adds information about unkn…
c9bf972 
…own type in `getMUCNotificationMessageFrom`
azlancpool referenced this issue Mar 10, 2021
@azlancpool
[cmp] #637 - Uses RoleUpdate structure instead of SelfRoleUpdate,…
f402ef1 
… the last one is unnecessary
azlancpool referenced this issue Mar 10, 2021
@azlancpool
[cmp] #637 - Uses AffiliationRoleUpdate structure instead of `SelfA…
09f9874 
…ffiliationRoleUpdate`, the last one is unnecessary
azlancpool referenced this issue Mar 10, 2021
@azlancpool
[cmp] #687 - Adds functions in order to improve the readability of me…
9350414 
…ssage functions and it improves a grammar mistakes
azlancpool referenced this issue Mar 10, 2021
@azlancpool
[cmp] #637 - Fixes test for getting messages for self affiliation and…
dd34642 
… role updated
azlancpool referenced this issue Mar 10, 2021
@azlancpool
[cm] ##628, #624, #644, #648, #651 - Replaces %[1]s by %s where i…
bb982d5 
…t's not neceessary
@azlancpool
Copy link
Contributor

This issue is ready to be reviewed by @olabiniV2

@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Mar 10, 2021
@olabiniV2
Copy link
Contributor

Things to fix.

@olabiniV2 olabiniV2 added State: Doing This story is currently in development and removed State: Test This story is in testing, either code review or user testing or both in-code-review This story is currently in state: test and should have code review done labels Mar 11, 2021
azlancpool referenced this issue Mar 11, 2021
@azlancpool
[cm] - Added . in messages in order to be consistent with others
8c3474e
@azlancpool
Copy link
Contributor

It's ready to be reviewed by @olabiniV2

@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Mar 12, 2021
@olabiniV2
Copy link
Contributor

OK

@olabiniV2 olabiniV2 removed the in-code-review This story is currently in state: test and should have code review done label Mar 12, 2021
@pedropalau pedropalau added State: Done This store is done - usually that means that the story should be closed. and removed State: Test This story is in testing, either code review or user testing or both labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimate - small MUC - Admin Capabilities Functionality MUC Admin Capabilities Functionality MUC Priority: Now State: Done This store is done - usually that means that the story should be closed.
Projects
None yet
Milestone
0.4 Release
Development

No branches or pull requests
5 participants
@pedropalau @azlancpool @rmendoza83 @Cris2760 @olabiniV2