Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be notified when you get to be an admin (10.6) #651

Closed
Cris2760 opened this issue Jul 20, 2020 · 8 comments
Closed

Be notified when you get to be an admin (10.6) #651

Cris2760 opened this issue Jul 20, 2020 · 8 comments
Labels
Estimate - small MUC - Room Owner Capabilities Functionality MUC Room Owner Capabilities Functionality MUC Priority: Now State: Done This store is done - usually that means that the story should be closed.
Milestone
0.4 Release

Comments

@Cris2760
Copy link

Cris2760 commented Jul 20, 2020 •
edited by olabiniV2

When adding the admin status to a user, you should be told if the operation succeeded or failed, and if it failed, why it failed.

Note: Please see the reference on https://xmpp.org/extensions/xep-0045.html
@Cris2760 Cris2760 added the MUC label Jul 20, 2020
@rmendoza83 rmendoza83 added the MUC - Room Owner Capabilities Functionality MUC Room Owner Capabilities Functionality label Jul 20, 2020
@olabiniV2
Copy link
Contributor

This is part of #271.

@Cris2760 Cris2760 changed the title Be notified when you get to be a admin (10.6) Be notified when you get to be an admin (10.6) Jan 4, 2021
@Cris2760 Cris2760 added the State: Ready This story is ready for development label Jan 5, 2021
@Cris2760 Cris2760 added this to the 0.4 Release milestone Jan 19, 2021
@MauroVelasco MauroVelasco added State: Doing This story is currently in development and removed State: Ready This story is ready for development labels Feb 12, 2021
MauroVelasco added a commit that referenced this issue Feb 12, 2021
@MauroVelasco
[cms] #651 - Generates a message for an event which contains affiliat…
06f9eaa 
…ion and role update
MauroVelasco added a commit that referenced this issue Feb 12, 2021
@MauroVelasco
[cms] #651 - Show a notification when an occupant gets administrator …
b400f4b 
…affiliation
@azlancpool azlancpool added in-user-test This story is currently in State: test and should have user testing done State: Test This story is in testing, either code review or user testing or both State: Doing This story is currently in development and removed State: Doing This story is currently in development State: Test This story is in testing, either code review or user testing or both in-user-test This story is currently in State: test and should have user testing done labels Feb 17, 2021
sacurio added a commit that referenced this issue Feb 18, 2021
@sacurio
[cs] #651 - Improves the notification messages shown when the occupan…
09d2b4b 
…t affiliation and role has been changed
@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Feb 18, 2021
@olabiniV2
Copy link
Contributor

There are some serious problems that need to be fixed. And more importantly, I can see that there's feedback from the user testing that hasn't been incorporated, so moving this to code review was incorrect to do in the first place.

@olabiniV2 olabiniV2 removed the State: Test This story is in testing, either code review or user testing or both label Feb 19, 2021
azlancpool added a commit that referenced this issue Mar 8, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651 - Changes in functionality that re…
af599bb 
…turns a message when the affiliation of an occupant has been added
azlancpool added a commit that referenced this issue Mar 8, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651, #633, #637 - Changes in functiona…
c12cde0 
…lity that returns a message when the affiliation and role of an occupant has been changed
azlancpool added a commit that referenced this issue Mar 8, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651, #633, #637 - Changes in functiona…
2a4920e 
…lity that returns a message when the affiliation and role of a self-occupant has been changed
azlancpool added a commit that referenced this issue Mar 9, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651 - Changes in functionality that re…
18ad24b 
…turns a message when the affiliation of a self-occupant has been changed
azlancpool added a commit that referenced this issue Mar 9, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651 - Changes in functionality that re…
f09f939 
…turns a message when an error occurred trying to change the affiliation
azlancpool added a commit that referenced this issue Mar 9, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651 - Removes `displayNameForAffiliati…
09b8cc1 
…on` and `displayNameForAffiliationWithPreposition` functions
azlancpool added a commit that referenced this issue Mar 9, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651, #633, #637 - Adds index in parame…
15fd73a 
…ters of `Localf` arguments
azlancpool added a commit that referenced this issue Mar 9, 2021
@azlancpool
[cmp] #628, #624, #644, #648, #651, #633, #637 - Changes sin `muc_not…
5d43b29 
…ification_message` in order to be more consistent
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] ##628, #624, #644, #648, #651 - Replaces %[1]s by %s where i…
bb982d5 
…t's not neceessary
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Uses panic instead of retur…
db3be77 
…ns a unfriendly message
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Removes default statement
2a5ec52
azlancpool added a commit that referenced this issue Mar 10, 2021
@azlancpool
[cm] #628, #644, #648, #651, #633, #637 - Adds information about unkn…
c9bf972 
…own type in `getMUCNotificationMessageFrom`
@azlancpool
Copy link
Contributor

This issue is ready to be reviewed by @olabiniV2

@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Mar 10, 2021
@olabiniV2
Copy link
Contributor

Things to fix.

@olabiniV2 olabiniV2 added State: Doing This story is currently in development and removed State: Test This story is in testing, either code review or user testing or both in-code-review This story is currently in state: test and should have code review done labels Mar 11, 2021
azlancpool referenced this issue Mar 11, 2021
@azlancpool
[cm] - Added . in messages in order to be consistent with others
8c3474e
@azlancpool
Copy link
Contributor

It's ready to be reviewed by @olabiniV2

@azlancpool azlancpool added in-code-review This story is currently in state: test and should have code review done State: Test This story is in testing, either code review or user testing or both and removed State: Doing This story is currently in development labels Mar 12, 2021
@olabiniV2
Copy link
Contributor

OK

@olabiniV2 olabiniV2 removed the in-code-review This story is currently in state: test and should have code review done label Mar 12, 2021
@pedropalau pedropalau added State: Done This store is done - usually that means that the story should be closed. and removed State: Test This story is in testing, either code review or user testing or both labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimate - small MUC - Room Owner Capabilities Functionality MUC Room Owner Capabilities Functionality MUC Priority: Now State: Done This store is done - usually that means that the story should be closed.
Projects
None yet
Milestone
0.4 Release
Development

No branches or pull requests
6 participants
@MauroVelasco @pedropalau @azlancpool @rmendoza83 @Cris2760 @olabiniV2