Skip to content
This repository has been archived by the owner on Jul 31, 2018. It is now read-only.

Minor changes #17

Merged
merged 2 commits into from
Feb 21, 2014
Merged

Minor changes #17

merged 2 commits into from
Feb 21, 2014

Conversation

jsilvestre
Copy link
Contributor

  • Fixed: the default plugin path was relative to "root", therefore an application couldn't be started in a subfolder (e.g. "build/"). It doesn't break anything due to node module loading strategy: check the ./node_modules, if not found, check ../node_modules and so on (then it gets more complicated, not relevant here).
  • Added: the afterStart hook had no parameter, the primary goal of this hook was to start things after server is started so those things could be bound to the server. app/server as parameters will solve that issue.

aenario added a commit that referenced this pull request Feb 21, 2014
@aenario aenario merged commit dffd3bf into cozy:master Feb 21, 2014
@frankrousseau
Copy link
Contributor

Could you provide more explaination about the way you manage plugins ?

The root parameter is there to allow the application to be started from any directory.

@frankrousseau
Copy link
Contributor

Ok I understand better, you don't load the plugin anymore from its absolute path. Are you sure that it doesn't break things?

Could you update the comment?

@jsilvestre
Copy link
Contributor Author

Romain and I have checked the node module loading order and it should be okay (I have tested this setup against the Home application).

The root parameter was just wrong for loading plugins, otherwise it works like a charm!

edit: do you mean the comment in the code?

@frankrousseau
Copy link
Contributor

Did you run tests?

I mean the comment in the code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants