Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Smaller build 1 #907

Merged
merged 3 commits into from
Feb 27, 2019
Merged

perf: Smaller build 1 #907

merged 3 commits into from
Feb 27, 2019

Conversation

ptbrowne
Copy link
Contributor

@ptbrowne ptbrowne commented Feb 15, 2019

Bigger issue : #926

Baseline: 2421ko

image

  • Remove duplicate lib via webpack aliasing : 2317ko

image

  • Do not bundle all d3 inside build : 2179ko

image

@ptbrowne ptbrowne changed the title perf: Smaller build WIP perf: Smaller build Feb 15, 2019
@nono
Copy link
Member

nono commented Feb 15, 2019

Some other ideas:

  • remove the Fetch polyfill (it is no longer needed for the browsers we support)
  • use lazy loading for the graphs libs
  • redux-raven-middleware and raven.js seems to load the same files: are both necessary?
  • try svgo on icon-collect-account.svg

@nono
Copy link
Member

nono commented Feb 15, 2019

Cozy Authentication build ? Why is it so big ?

It embeds 65ko of CSS from cozy-ui, and some stylus things

@ptbrowne ptbrowne changed the title WIP perf: Smaller build perf: Smaller build Feb 21, 2019
@ptbrowne ptbrowne mentioned this pull request Feb 22, 2019
5 tasks
@ptbrowne ptbrowne changed the title perf: Smaller build perf: Smaller build 1 Feb 22, 2019
@kosssi
Copy link
Contributor

kosssi commented Feb 26, 2019

I don’t see the interest in minifying image, it should be webpack that handles this, no ?

Tomorrow when we add another image we forgot to minify it, ...

@nono
Copy link
Member

nono commented Feb 26, 2019

Well, there are some pros and cons to do that. For example, minifying images can take a lot of time and make the build really slower.

@ptbrowne ptbrowne closed this Feb 27, 2019
@ptbrowne ptbrowne reopened this Feb 27, 2019
@kosssi kosssi merged commit 362cc6b into master Feb 27, 2019
@kosssi kosssi deleted the smaller-build branch February 27, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants