Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check cozyclient version to call instance info #664

Merged
merged 4 commits into from
Nov 29, 2019

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Nov 29, 2019

check cozyclient version before calling new functions

Wanted to add a few tests for the component, but it requires more work since enzyme et enzyme react adapter are pretty old. An upgrade breaks other tests...

@Crash-- Crash-- requested a review from edas as a code owner November 29, 2019 09:56
yarn.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some suggestions

src/components/Settings/index.jsx Outdated Show resolved Hide resolved
src/components/Settings/helper.js Show resolved Hide resolved
@Crash-- Crash-- merged commit e6344e6 into master Nov 29, 2019
@Crash-- Crash-- deleted the fix/DisplayButtonOffers branch November 29, 2019 10:59
@cozy-bot
Copy link

🎉 This PR is included in version 7.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants