This repository has been archived by the owner on Oct 28, 2020. It is now read-only.
Fixes #33: Look for the opening curly brace when defining a request i… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this fixes the naming issue, and I also wrapped the Function call in a try/catch block. Can you take a look please, @aenario ? |
| try | ||
| map = new Function "doc", stringquery | ||
| catch e | ||
| callback "Error when parsing the request body: #{e.toString()}" |
There was a problem hiding this comment.
I think you should create an error object here.
…st in the pouchdb's adapter.
|
Hehe, I tend to use single-letter named variables when their scope is really small, as one can still find the variable's name just by looking a bit higher. However, I've fixed it to use your guidelines here. Pull request has been updated, please have another look. |
aenario
pushed a commit
that referenced
this pull request
Sep 25, 2015
|
Thank you for the fixes. About single letter variable, it's definitely wrong : poor meaning and hard to rename. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n the pouchdb's adapter.