This repository has been archived by the owner on Jun 12, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Improve messages workflow #814
Merged
m4dz
merged 58 commits into
cozy:development
from
misstick:enhancement/messages-manipulation
Apr 19, 2016
Merged
Improve messages workflow #814
m4dz
merged 58 commits into
cozy:development
from
misstick:enhancement/messages-manipulation
Apr 19, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misstick
force-pushed
the
enhancement/messages-manipulation
branch
3 times, most recently
from
April 6, 2016 13:46
fe7b220
to
845234b
Compare
I didn't notice before but it looks like you don't follow the 80 chars guideline. Could you stick to it? It makes the text size standard, force to write more concise code and match with what we do since the beginning. |
misstick
force-pushed
the
enhancement/messages-manipulation
branch
5 times, most recently
from
April 13, 2016 14:52
ceb9c9d
to
a3293c6
Compare
4 tasks
misstick
force-pushed
the
enhancement/messages-manipulation
branch
2 times, most recently
from
April 18, 2016 13:09
41e88c4
to
a97e972
Compare
misstick
force-pushed
the
enhancement/messages-manipulation
branch
from
April 19, 2016 07:34
a97e972
to
99271e9
Compare
misstick
force-pushed
the
enhancement/messages-manipulation
branch
from
April 19, 2016 10:28
b3bd0c3
to
dc1de11
Compare
@@ -66,7 +66,7 @@ module.exports = GlobalSearchBar = React.createClass | |||
.toOrderedMap() | |||
.set 'all', t 'search all accounts' | |||
|
|||
accountID = AccountStore.getSelected()?.get('id') or 'all' | |||
accountID = AccountStore.getAccountID() or 'all' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use a getter here, nope?
I merge as it, maybe we need to think about:
We also need to add a lot of comments in the whole app: each time I review, it's deeply hard to understand who does what, how, and what have changed 😞… |
@m4dz :
|
12 tasks
misstick
pushed a commit
to misstick/cozy-emails
that referenced
this pull request
Apr 28, 2016
…lation Improve messages workflow
Merged
13 tasks
misstick
pushed a commit
to misstick/cozy-emails
that referenced
this pull request
May 9, 2016
…lation Improve messages workflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve features
unread messages counter
into menu as fast as possible,nextURL
setting,conversationLength
,currentID
when Route changes,top
andbottom
keys,filter
navigation,selection
,- [ ]selection
menu: remove tools submenu to display simple buttonsRemove features
search bar
is useless (search is broken),filter toolbar
,unread
,important
,