Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Improve messages workflow #814

Merged
merged 58 commits into from
Apr 19, 2016

Conversation

misstick
Copy link
Contributor

@misstick misstick commented Apr 6, 2016

Improve features

  • upgrade unread messages counter into menu as fast as possible,
  • active realtime events,
  • fix nextURL setting,
  • do not fetch all messages to get conversationLength,
  • fetch all messages from conversation when a message is displayed,
  • show only current message on 2nd panel,
  • reset currentID when Route changes,
  • clean messageList dead code,
  • fix keyboard navigation for top and bottom keys,
  • fix filter navigation,
  • fix checkbox selection,

- [ ] selection menu: remove tools submenu to display simple buttons

Remove features

  • search bar is useless (search is broken),
  • filter toolbar,
  • add mailbox unread,
  • add mailbox important,
  • compose was re-added but should disappear, see: Disable Compose feature #807

@misstick misstick force-pushed the enhancement/messages-manipulation branch 3 times, most recently from fe7b220 to 845234b Compare April 6, 2016 13:46
@frankrousseau
Copy link
Contributor

I didn't notice before but it looks like you don't follow the 80 chars guideline. Could you stick to it? It makes the text size standard, force to write more concise code and match with what we do since the beginning.

@misstick misstick changed the title Improve messages display Improve messages workflow Apr 7, 2016
@misstick misstick force-pushed the enhancement/messages-manipulation branch 5 times, most recently from ceb9c9d to a3293c6 Compare April 13, 2016 14:52
@misstick misstick force-pushed the enhancement/messages-manipulation branch 2 times, most recently from 41e88c4 to a97e972 Compare April 18, 2016 13:09
@misstick misstick force-pushed the enhancement/messages-manipulation branch from a97e972 to 99271e9 Compare April 19, 2016 07:34
@misstick misstick force-pushed the enhancement/messages-manipulation branch from b3bd0c3 to dc1de11 Compare April 19, 2016 10:28
@@ -66,7 +66,7 @@ module.exports = GlobalSearchBar = React.createClass
.toOrderedMap()
.set 'all', t 'search all accounts'

accountID = AccountStore.getSelected()?.get('id') or 'all'
accountID = AccountStore.getAccountID() or 'all'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use a getter here, nope?

@m4dz
Copy link
Contributor

m4dz commented Apr 19, 2016

I merge as it, maybe we need to think about:

  • using Getter in component and never call Stores directly
  • Use dedicated getters for stores like MessagesStores, and not let RouterGetter serves contents that doesn't rely directly on it (like getMessagesList, which should be in a MessagesGetter that can ask RouterSTore for the current mailboxID)

We also need to add a lot of comments in the whole app: each time I review, it's deeply hard to understand who does what, how, and what have changed 😞…

@m4dz m4dz merged commit 1fb4924 into cozy:development Apr 19, 2016
@misstick
Copy link
Contributor Author

@m4dz :

  • " using Getter in component and never call Stores directly" : this should be done a little each time
  • for getter, we could talk about this; to my mind, having only one getter si enought but its name should be change in getters/application ie.

misstick pushed a commit to misstick/cozy-emails that referenced this pull request Apr 28, 2016
m4dz added a commit that referenced this pull request Apr 28, 2016
@m4dz m4dz mentioned this pull request Apr 28, 2016
misstick pushed a commit to misstick/cozy-emails that referenced this pull request May 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants