fix: improve app creation realtime management #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (2)
Unchanged files (11)
Total files change +286B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
acezard
force-pushed
the
fix--improve-app-creation-realtime-management
branch
2 times, most recently
from
02e0c55
to
8e2fcae
Compare
Crash--
reviewed
Apr 25, 2023
src/components/AppTile.jsx
Outdated
| } | ||
|
|
||
| export default translate()(AppTile) | ||
| export default translate()(AppTileWrapper) |
There was a problem hiding this comment.
tu peux dégager le hoc pour utiliser un useI18n()
Crash--
reviewed
Apr 25, 2023
src/queries.js
Outdated
|
|
||
| export const fetchAppInfo = async (appId, client) => { | ||
| const appQuery = Q('io.cozy.apps').getById(appId) | ||
| const { data } = await client.query(appQuery, { as: 'fetchAppInfoReady' }) |
There was a problem hiding this comment.
Tu ne peux pas appeler ton alias (as) ainsi parce que tout le cache de cozy-client est basé sur ce as...
Introduce AppTileWrapper component to handle installing state on realtime app installation
acezard
force-pushed
the
fix--improve-app-creation-realtime-management
branch
from
8e2fcae
to
7fa57fd
Compare
Crash--
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AppTile not updating when app state changes from 'installing' to 'ready'
Issue:
The AppTile component was not correctly updating when an app's state changed from
'installing'to'ready'. This resulted in the app icon staying as a placeholder forever in persistent scenarios (native).Solution:
To resolve this issue, we introduced a new wrapper component,
AppTileWrapper, responsible for managing the app's state and fetching the app's information when the state changes from'installing'to'ready'. TheAppTileWrappercomponent utilizes auseEffecthook to detect the change in the app's state and fetch the updated app information accordingly.When the app's information is unavailable (i.e., the app is in the
'installing'state),AppTileWrapperrenders a loading icon using theSquareAppIconcomponent. Once the app's state changes to'ready'and the information is fetched,AppTileWrapperrenders theAppTilecomponent, displaying the app icon with a link to the app.Additionally, we updated the test suite to cover the new component behaviour, ensuring that the
AppTileis rendered when the app is in the'ready'state and updates when the app's state transitions from'installing'to'ready'.With these changes, the
AppTilecomponent now correctly updates its state and displays the correct information when an app's state changes from'installing'to'ready'.Video example:
Android.Emulator.-.Nexus_5X_API_30_5554.2023-04-24.17-29-26.mp4