Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement group section mode (VO-739) (VO-754) #2128

Merged
merged 16 commits into from
Jun 26, 2024

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Jun 3, 2024

No description provided.

@acezard acezard force-pushed the feat--Implement-group-section-mode branch from c288f46 to 79bd25e Compare June 3, 2024 14:32
Copy link

bundlemon bot commented Jun 3, 2024

BundleMon

Files updated (4)
Status Path Size Limits
app/home.(hash).js
40.8KB (+2.96KB +7.83%) 50KB
intents/home.(hash).js
24.83KB (+2.72KB +12.31%) 35KB
vendors/home.(hash).js
1.47MB (+913B +0.06%) 1.5MB
app-home.(hash).min.css
1.65KB (+269B +18.98%) 15KB
Unchanged files (9)
Status Path Size Limits
services/softDeleteOrRestoreAccounts/home.js
463.15KB 490KB
services/updateAccounts/home.js
460.29KB 467KB
services/deleteAccounts/home.js
308.43KB 500KB
services/myselfFromIdenties/home.js
233.07KB 245KB
services/polyfillFetch/home.js
97.36KB 99KB
vendors-home.(hash).(hash).min.css
38.79KB 40KB
services/attributesHelpers/home.js
15.22KB 16KB
intents/index.html
651B 1KB
intents-home.(hash).min.css
158B 6KB

Total files change +6.84KB +0.21%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

src/components/Shortcuts/index.jsx Outdated Show resolved Hide resolved
src/components/Sections/SectionDialog.tsx Show resolved Hide resolved
src/components/Sections/SectionHeader.tsx Outdated Show resolved Hide resolved
src/components/Sections/utils.ts Outdated Show resolved Hide resolved
src/components/Sections/utils.ts Outdated Show resolved Hide resolved
src/components/Sections/utils.ts Outdated Show resolved Hide resolved
src/components/Sections/GroupedSectionsView.tsx Outdated Show resolved Hide resolved
@acezard acezard marked this pull request as ready for review June 14, 2024 14:20
@acezard acezard requested a review from doubleface as a code owner June 14, 2024 14:20
@acezard acezard requested review from Ldoppea and JF-Cozy June 14, 2024 14:20
@acezard acezard force-pushed the feat--Implement-group-section-mode branch from dd77250 to 802d14f Compare June 17, 2024 14:41
@acezard acezard changed the title feat: Implement group section mode (VO-739) feat: Implement group section mode (VO-739) (VO-754) Jun 24, 2024
@acezard acezard force-pushed the feat--Implement-group-section-mode branch from 905897e to 02dc35b Compare June 24, 2024 13:41
src/components/AppWrapper.jsx Outdated Show resolved Hide resolved
src/components/Home.jsx Outdated Show resolved Hide resolved
src/components/Sections/GroupedSectionsView.tsx Outdated Show resolved Hide resolved
? groupedSections?.find(section => section.id === category)
: null

const handleGoBack = (): void => navigate(-1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember a discussion with Quentin where he warned me not to use the -1 because it wouldn't work on the flagship app. We use relative paths to avoid this problem. From what I understood, it's because webviews don't have web history, but maybe that's not true any more? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to investigate, I don't remember the specifics. But indeed when going back from the dialog, we leave the native app

src/components/Shortcuts/index.tsx Outdated Show resolved Hide resolved
@acezard acezard force-pushed the feat--Implement-group-section-mode branch from 5acb895 to 6b3a9e9 Compare June 25, 2024 13:20
@acezard acezard requested a review from cballevre June 25, 2024 13:26
@acezard acezard merged commit ec8438d into master Jun 26, 2024
3 checks passed
@acezard acezard deleted the feat--Implement-group-section-mode branch June 26, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants