-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement group section mode (VO-739) (VO-754) #2128
Conversation
c288f46
to
79bd25e
Compare
BundleMonFiles updated (4)
Unchanged files (9)
Total files change +6.84KB +0.21% Final result: ✅ View report in BundleMon website ➡️ |
dd77250
to
802d14f
Compare
905897e
to
02dc35b
Compare
? groupedSections?.find(section => section.id === category) | ||
: null | ||
|
||
const handleGoBack = (): void => navigate(-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember a discussion with Quentin where he warned me not to use the -1 because it wouldn't work on the flagship app. We use relative paths to avoid this problem. From what I understood, it's because webviews don't have web history, but maybe that's not true any more? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to investigate, I don't remember the specifics. But indeed when going back from the dialog, we leave the native app
- does not include modal view
Still some last fixes needed on typography
remain router issue
5acb895
to
6b3a9e9
Compare
No description provided.