Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvest: Check after tx pull ☑ #602

Merged
merged 1 commit into from Jul 3, 2019
Merged

Harvest: Check after tx pull ☑ #602

merged 1 commit into from Jul 3, 2019

Conversation

gregorylegarec
Copy link
Contributor

Reused the script from cozy/cozy-home#1076.

This PR adds a locales check after a tx pull.

The build will fail if locales files do not match.

It will prevent releases with missing fr translations.

@gregorylegarec gregorylegarec self-assigned this Jul 3, 2019
@gregorylegarec gregorylegarec added the ✨ Enhancement New feature or request label Jul 3, 2019
ptbrowne
ptbrowne approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should do that in Banks too !

@ptbrowne ptbrowne mentioned this pull request Jul 3, 2019
Closed
@gregorylegarec gregorylegarec merged commit 5c4077b into master Jul 3, 2019
@ptbrowne ptbrowne deleted the feat/harvest/check-locales branch February 13, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne ptbrowne approved these changes

@CPatchane CPatchane CPatchane approved these changes

@Crash-- Crash-- Awaiting requested review from Crash--

Assignees

@gregorylegarec gregorylegarec

Labels
✨ Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gregorylegarec @ptbrowne @CPatchane