Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long nav link causes overflow from hover background #97

Closed
ptbrowne opened this issue May 3, 2017 · 6 comments
Closed

Long nav link causes overflow from hover background #97

ptbrowne opened this issue May 3, 2017 · 6 comments

Comments

@ptbrowne
Copy link
Contributor

ptbrowne commented May 3, 2017

image

@ptbrowne
Copy link
Contributor Author

ptbrowne commented May 3, 2017

With a bit of CSS

image

.coz-nav-link {
    text-overflow: ellipsis;
    white-space: nowrap;
    overflow: hidden;
}

Should I make a PR ?

@GoOz
Copy link
Contributor

GoOz commented May 3, 2017

Are we sure we want an ellipsis and not a return? I'm kinda skeptical about cuting nav entries but just asking, really.
@kelukelu what do you think?

@kelukelu
Copy link
Contributor

kelukelu commented May 3, 2017

I'm agree.
A return seems to be a better choice.
We should ask EDF to find a shorter/better name also: "realiser des economies" seems like an action to me. Not really the best name for a tab...

@GoOz
Copy link
Contributor

GoOz commented May 3, 2017

Indeed, they should find the most suitable short term but as this is not always possible, let's go for a return. Thanks @kelukelu.

@ptbrowne
Copy link
Contributor Author

ptbrowne commented May 3, 2017

Return is ugly but OK

image

GoOz pushed a commit that referenced this issue May 4, 2017
* fix(nav): fix overflowing text from hover. #97

* fix(nav): line break instead of ellipsis

* chore: duplicate selector

* fix(nav): little padding on nav-item to be pretty on hover

* lint 😆 🔫
@GoOz
Copy link
Contributor

GoOz commented May 4, 2017

Fixed with #98

@GoOz GoOz closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants