fix: show spinner when needed in squareappIcon #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezard
requested review from
JF-Cozy,
Merkur39,
Ldoppea and
zatteo
as code owners
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Previously it was rendered too liberally. Now it is rendered only when - Component is in "loading" variant - Component has an animationState (success or failed), which triggers after a loading finishes. We need this because we don't want to hide the spinner as soon as the loading is over We want to wait for the ending animation too so the transition looks smooth. Also refactored the spinner logic out of the main component for clarity
Ldoppea
force-pushed
the
fix--only-show-spinner-when-needed-in-squareappIcon
branch
from
97b3211
to
575f1aa
Compare
Ldoppea
approved these changes
May 12, 2023
|
🎉 This PR is included in version 85.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ldoppea
added a commit
to cozy/cozy-home
that referenced
this pull request
May 12, 2023
`cozy-ui` has been upgraded to `85.0.1` to retrieve a fix that hide the SquareAppIcon spinner when a connector is not running Related PR: cozy/cozy-ui#2436
Ldoppea
added a commit
to cozy/cozy-home
that referenced
this pull request
May 12, 2023
`cozy-ui` has been upgraded to `85.0.1` to retrieve a fix that hide the SquareAppIcon spinner when a connector is not running Related PR: cozy/cozy-ui#2436
Ldoppea
added a commit
to cozy/cozy-home
that referenced
this pull request
May 12, 2023
`cozy-ui` has been upgraded to `85.0.1` to retrieve a fix that hide the SquareAppIcon spinner when a connector is not running Related PR: cozy/cozy-ui#2436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was rendered too liberally.
Now it is rendered only when
which triggers after a loading finishes. We need this
because we don't want to hide the spinner as soon as the loading is over
We want to wait for the ending animation too so the transition looks
smooth.
Also refactored the spinner logic out of the main component for clarity