feat: Add accounts paywall #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
force-pushed
the
feat/add-accounts-paywall
branch
from
3aaa312
to
e6469c1
Compare
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
cballevre
force-pushed
the
feat/add-accounts-paywall
branch
from
e6469c1
to
0612307
Compare
JF-Cozy
reviewed
Jun 14, 2023
cballevre
force-pushed
the
feat/add-accounts-paywall
branch
from
0612307
to
13ebffb
Compare
JF-Cozy
approved these changes
Jun 15, 2023
| import fr from './locales/fr.json' | ||
| import en from './locales/en.json' | ||
|
|
||
| const locales = { |
There was a problem hiding this comment.
à penser dans une prochaine refacto si t'es un peu juste en temps sur cette PR, mais tu peux faire une méthode withPaywallLocales qui va se charger d'importer les locales et withOnlyLocales. Tu as des exemples avec le Viewer ou les ListItem, ça t'évite de devoir importer les locales dans chaque composant
There was a problem hiding this comment.
j'ai pris un peu de temps pour utiliser une méthode withPaywallLocales sur tous les Paywalls qui en avait besoin j'y penserais pour mes prochaines PR sur cozy-ui ;)
This modification was done by the CLI
cballevre
force-pushed
the
feat/add-accounts-paywall
branch
from
13ebffb
to
76d15ca
Compare
|
🎉 This PR is included in version 85.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live demo