Add support for authsae on adhoc interfaces #1
Conversation
|
Hi Will, Why don' t you take this a bit further and make it possible to support both modes in one binary. Also, the respective join / leave commands seems to overlap quite a bit, do you think you could unify the mesh / ibss versions of these? Thanks, |
|
Happy to! I will send further updates either later tonight or tomorrow! Until then, |
|
Hello Thomas! Take a look at the commits I just added to this pull request. There were definitely some things that I needed to improve in the code that I submitted yesterday. Thank you for giving me the chance to do that. Let me know if there are other things that you need me to address! Will |
|
Will, Looks like you have some good changes here, can you please squash some of these commits together so you don't introduce a bunch of code in one patch only to change / remove it in the next? This will make the series easier to review. Also, we try to follow linux kernel coding style. See http://www.kernel.org/doc/Documentation/CodingStyle for more info. Thanks! |
1. Move channel_to_freq up in the source code so that it can be used in join_network. 2. Combine join_mesh_rsn and join_ibss into one function. 3. Combine leave_mesh and leave_ibss into one function. 4. Rename register_for_plink_frames to register_for_action_frames. 5. Add and use a "using adhoc" flag. 6. Add support for pretty-printing a failing command. 7. Define the maximum length of the BSSID string 8. Add space for BSSID in meshd config
|
Thanks for your comments, Thomas. I am closing this pull request and replacing it with another one that I think will meet your standards! :-) Will |
Hello!
These are preliminary changes to your authsae code to add support for adhoc interfaces. For these changes to actually work, there are certain changes that must be made to the kernel. I am attempting to upstream those in parallel with submitting these patches. I'd be happy to provide them patch set to you for testing, if you'd like.
I think that the authsae code well written and easy to read. The security that authsae provides is a much-needed feature for us and I am excited about the chance to contribute my code to this work. Please let me know if there are changes that you'd like to see before accepting this pull request. I tried to be consistent with the existing style but I may not have succeeded in every case.
Will