Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fprettify to current master #270

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Update fprettify to current master #270

merged 2 commits into from
Nov 25, 2019

Conversation

pseewald
Copy link
Contributor

This will fix formatting issue with FORD documentation

This will fix formatting issue with FORD documentation
@alazzaro
Copy link
Member

I think, this PR also includes the #95 issue, right?

@pseewald
Copy link
Contributor Author

in fprettify this was fixed, but the DBCSR makefile still has the workaround - thanks for mentioning, I'll include it in this PR.

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #270 into develop will increase coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #270     +/-   ##
=========================================
+ Coverage     60.2%   60.2%   +<.1%     
=========================================
  Files           96      96             
  Lines        22963   22963             
=========================================
+ Hits         13839   13840      +1     
+ Misses        9124    9123      -1
Impacted Files Coverage Δ
src/core/dbcsr_list_callstackentry.F 100% <ø> (ø) ⬆️
src/core/dbcsr_list_routinereport.F 100% <ø> (ø) ⬆️
src/ops/dbcsr_operations.F 33.5% <ø> (ø) ⬆️
src/tensors/dbcsr_tensor_types.F 87.4% <ø> (ø) ⬆️
src/tas/dbcsr_tas_test.F 64.4% <ø> (ø) ⬆️
src/core/dbcsr_print_messages.F 80.7% <ø> (ø) ⬆️
src/core/dbcsr_list_routinestat.F 100% <ø> (ø) ⬆️
src/base/dbcsr_machine_posix.f90 20% <ø> (ø) ⬆️
src/tensors/dbcsr_array_list_methods.F 100% <ø> (ø) ⬆️
src/utils/dbcsr_files.F 36.1% <ø> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b8461...c76b76b. Read the comment docs.

@alazzaro
Copy link
Member

LGTM, I wonder if we can have pretty as part of the pre-commit stuff and eventually cmake...
As far I can tell, for the moment it is only part of the "deprecated" makefile...

@dev-zero any ^^

@dev-zero
Copy link
Contributor

@alazzaro cmake no, pre-commit yes

@pseewald pseewald merged commit b88a1c7 into cp2k:develop Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants