Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makedep.py: match CP2K's makedep.py #437

Merged
merged 1 commit into from
Mar 17, 2021
Merged

makedep.py: match CP2K's makedep.py #437

merged 1 commit into from
Mar 17, 2021

Conversation

hfp
Copy link
Member

@hfp hfp commented Mar 17, 2021

  • Removed superfluous fhandle.close().
  • Open files UTF8-encoded (CP2K).
  • Fixed some typos.

* Removed superfluous fhandle.close().
* Open files UTF8-encoded.
* Fixed some typos.
@hfp
Copy link
Member Author

hfp commented Mar 17, 2021

Daint-CI seems to have a regression of the environment: CMake 3.17 or higher is required. You are running version 3.10.2 (see build-714). I believe CMake version was sufficient recently and updated to recent needs.

@alazzaro
Copy link
Member

alazzaro commented Mar 17, 2021

@hfp You are right, Daint was updated yesterday and now there is a new module to load:

cdt-cuda

However, I see that the CMake is still old:

CMake/3.14.5(default)

I will inquire with CSCS if we can have new CMake installed...

@hfp
Copy link
Member Author

hfp commented Mar 17, 2021

Let's have a separate PR (if necessary) to account for updated Daint (build scripts, etc.).

@hfp hfp merged commit 272ca6b into cp2k:develop Mar 17, 2021
@alazzaro
Copy link
Member

Replay by CSCS:

You should be able to load the CMake 3.18.4 module with

module load /apps/daint/UES/jenkins/7.0.UP02/gpu/easybuild/modules/all/CMake/3.18.4

@hfp hfp mentioned this pull request Mar 17, 2021
@hfp hfp deleted the cleanup branch March 18, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants