-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add install target for CMake #48
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydden
changed the title
add install target for CMake (shared libs only)
[WIP] add install target for CMake
Oct 18, 2018
Codecov Report
@@ Coverage Diff @@
## develop #48 +/- ##
===========================================
- Coverage 57.34% 57.33% -0.02%
===========================================
Files 91 91
Lines 20085 20080 -5
===========================================
- Hits 11517 11512 -5
Misses 8568 8568
Continue to review full report at Codecov.
|
davydden
changed the title
[WIP] add install target for CMake
add install target for CMake
Oct 18, 2018
davydden
force-pushed
the
cmake/install
branch
from
October 18, 2018 11:35
65ca590
to
1b3f023
Compare
dev-zero
added a commit
that referenced
this pull request
Oct 19, 2018
Merged
superseeded by #55 |
dev-zero
added a commit
that referenced
this pull request
Oct 19, 2018
dev-zero
added a commit
that referenced
this pull request
Oct 19, 2018
dev-zero
added a commit
that referenced
this pull request
Oct 19, 2018
shoshijak
pushed a commit
to shoshijak/dbcsr
that referenced
this pull request
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #45
Currently, this works only when building with-DBUILD_SHARED_LIBS=ON
. I did not dig into CMake documentation to figure out how to fix this for static builds, but I will have a look...