Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add install target for CMake #48

Closed
wants to merge 1 commit into from
Closed

Conversation

davydden
Copy link
Contributor

@davydden davydden commented Oct 18, 2018

fixes #45

Currently, this works only when building with -DBUILD_SHARED_LIBS=ON. I did not dig into CMake documentation to figure out how to fix this for static builds, but I will have a look...

@davydden davydden changed the title add install target for CMake (shared libs only) [WIP] add install target for CMake Oct 18, 2018
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #48 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
- Coverage    57.34%   57.33%   -0.02%     
===========================================
  Files           91       91              
  Lines        20085    20080       -5     
===========================================
- Hits         11517    11512       -5     
  Misses        8568     8568
Impacted Files Coverage Δ
src/block/dbcsr_block_operations.f90 49.56% <0%> (-1.29%) ⬇️
src/block/dbcsr_block_operations.F 67.82% <0%> (-0.48%) ⬇️
src/block/dbcsr_block_access.f90 48.63% <0%> (-0.28%) ⬇️
src/data/dbcsr_ptr_util.f90 81.13% <0%> (-0.18%) ⬇️
src/block/dbcsr_iterator_operations.F 86.89% <0%> (+0.09%) ⬆️
src/mm/dbcsr_mm_csr.F 79.31% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad04585...1b3f023. Read the comment docs.

@davydden davydden changed the title [WIP] add install target for CMake add install target for CMake Oct 18, 2018
@davydden
Copy link
Contributor Author

superseeded by #55

@davydden davydden closed this Oct 19, 2018
dev-zero added a commit that referenced this pull request Oct 19, 2018
dev-zero added a commit that referenced this pull request Oct 19, 2018
dev-zero added a commit that referenced this pull request Oct 19, 2018
@dev-zero dev-zero mentioned this pull request Oct 19, 2018
3 tasks
shoshijak pushed a commit to shoshijak/dbcsr that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake: install target missing
1 participant