RawSignal.Multiply is 0 when doing plugin initialization, it must not be used to do divisions #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itCall and so we must not use its value to perform "const" computation. This leads to crashes when the image is built in debug mode.
|
Bonjour @obones, ne penses-tu pas qu'il faudrait plutot revoir le code en amont : y'a-t-il un intérêt à appeler PluginInitCall tout court? Je n'ai pas/peu identifié de code parculier d'initialisation de plugins, et toi ? |
|
Ah bah j'ai un gros doute sur son utilité effectivement, je n'ai pas vu de tel plugin non plus. Mais en l'état, je suis allé au moins intrusif sur le coeur de l'appli |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens via PluginInitCall and so we must not use its value to perform "const" computation.
This leads to crashes when the image is built in debug mode.