On bracket expression negation

[tomruk]

^ is escaped, but it works with gitignore.

To test it:

mkdir test && cd test
git init
echo 'a[^b]c' > .gitignore
touch abc azc
git status -u --ignored

Notice that abc doesn't match but azc does match. pathspec's behavior with ^ is inconsistent with Git.

I read:

python-pathspec/pathspec/patterns/gitwildmatch.py

Line 313 in 6fd6bee

# POSIX declares that the regex bracket expression negation

But I didn't understand why would you prefer to be compatible with POSIX and Python's fnmatch.translate when you could be compatible with gitignore itself. May I ask what led you to the decision to escape ^?

[cpburnz]

From the comment I have there:

POSIX declares that the regex bracket expression negation
"[^...]" is undefined in a glob pattern. Python's
fnmatch.translate() escapes the caret ('^') as a
literal. To maintain consistency with undefined behavior,
I am escaping the '^' as well.

My intent was to maintain the undefined behavior I was aware of. It does makes more sense to follow Git's behavior.

[tomruk]

Okay, let's follow Git's behavior: #78