improved readability of OpenASIP.tex with minor grammar fixes #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, much appreciated! Your fork seems to be a few commits behind the branch during which there have been modifications to the manual, eg. "/tce/" paths have been updated to "/openasip/". Could you rebase your fork to get these changes pulled in? Thanks! |
karihepola
requested changes
Sep 20, 2022
| @@ -587,7 +587,7 @@ \subsection{Starting Point Processor Architecture} | |||
| file: | |||
|
|
|||
| \begin{verbatim} | |||
| cp $(tce-config --prefix)/share/openasip/data/mach/minimal.adf start.adf | |||
| cp $(tce-config --prefix)/share/tce/data/mach/minimal.adf start.adf | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -1617,7 +1617,7 @@ \subsection{Generating the VHDL and memory images} | |||
| \item% | |||
| Select implementations for register files and function units all at once: | |||
| Click Auto Select Implementations, find the OpenASIP's default HDB file from your | |||
| OpenASIP installation path (PREFIX/share/openasip/hdb/asic\_130nm\_1.5V.hdb), make sure | |||
| OpenASIP installation path (PREFIX/share/tce/hdb/asic\_130nm\_1.5V.hdb), make sure | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -1639,7 +1639,7 @@ \subsection{Generating the VHDL and memory images} | |||
| %\item% | |||
| %Next select the IC/Decoder generator plugin used to generate the | |||
| %decoder in the control unit and interconnection network: | |||
| %\textit{Browse... (installation\_path)/share/openasip/icdecoder\_plugins/base/ | |||
| %\textit{Browse... (installation\_path)/share/tce/icdecoder\_plugins/base/ | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -1953,7 +1953,7 @@ \section{Hello OpenASIP World!} | |||
| the STDOUT function unit, which you can use: | |||
|
|
|||
| \begin{verbatim} | |||
| cp $(tce-config --prefix)/share/openasip/data/mach/minimal_with_stdout.adf . | |||
| cp $(tce-config --prefix)/share/tce/data/mach/minimal_with_stdout.adf . | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -3044,7 +3044,7 @@ \section{Designing Floating-point Processors with OpenASIP} | |||
| to tcecc enables the software emulation library linkage. | |||
|
|
|||
| A set of floating-point FU implementations is included with OA, in a HDB file named | |||
| \emph{fpu\_embedded.hdb}, which can be found at \emph{PREFIX/share/openasip/hdb/fpu\_embedded.hdb}. | |||
| \emph{fpu\_embedded.hdb}, which can be found at \emph{PREFIX/share/tce/hdb/fpu\_embedded.hdb}. | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -3166,7 +3166,7 @@ \subsection{Single-precision Function Units} | |||
|
|
|||
| \subsection{Half-precision Support} | |||
|
|
|||
| A set of half-precision arithmetic units is included with tce in \emph{PREFIX/share/openasip/hdb/fpu\_half.hdb}. In C and C++, | |||
| A set of half-precision arithmetic units is included with tce in \emph{PREFIX/share/tce/hdb/fpu\_half.hdb}. In C and C++, | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -3539,7 +3539,7 @@ \subsection{Tour to Using the Hardware Loops} | |||
| instructions to control-unit in the TTA design. To start with, \textbf{copy | |||
| minimalist TTA machine by}: | |||
|
|
|||
| \shellcmd{cp \$(tce-config -{}-prefix)/share/openasip/data/mach/minimal.adf hwloop.adf} | |||
| \shellcmd{cp \$(tce-config -{}-prefix)/share/tce/data/mach/minimal.adf hwloop.adf} | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -3818,7 +3818,7 @@ \subsection{Starting Point Processor Architecture} | |||
| file: | |||
|
|
|||
| \begin{verbatim} | |||
| cp $(tce-config --prefix)/share/openasip/data/mach/riscv.adf start.adf | |||
| cp $(tce-config --prefix)/share/tce/data/mach/riscv.adf start.adf | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
| @@ -5317,13 +5320,13 @@ \section{OSAL search paths} | |||
| System-wide shared custom operations: | |||
| \textit{TCE\_INSTALLATION\_DIR/opset/base/} \\ where | |||
| TCE\_INSTALLATION\_DIR is the path where TCE accessories is installed (for | |||
| example /usr/local/share/openasip). | |||
| example /usr/local/share/tce). | |||
There was a problem hiding this comment.
Replace /tce/ with /openasip/
|
|
||
| \item | ||
| Default predefined and standard operations: \\ | ||
| \textit{TCE\_INSTALLATION\_DIR/opset/base/} \\ where | ||
| TCE\_INSTALLATION\_DIR is the path where TCE accessories is installed (for | ||
| example /usr/local/share/openasip). | ||
| example /usr/local/share/tce). |
There was a problem hiding this comment.
Replace /tce/ with /openasip/
|
Is this to be merged? |
|
Hello. I am in the process of going through the entire user manual, where
before I was just focusing on one section. Could you cancel that merge
request for the time being and I'll make sure that the next one covers the
entire manual. I will follow through with this. Thank you for your patience.
(S)
…On Mon, Nov 14, 2022 at 6:42 AM Pekka Jääskeläinen ***@***.***> wrote:
Is this to be merged?
—
Reply to this email directly, view it on GitHub
<#178 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2UICHPAN4FI2MJAOBFOEETWIIQSLANCNFSM6AAAAAAQL3NWJA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very sorry it took longer than it should have. Please advise me if there are any problems with this pull request.