Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Java): use the class name as the name of the temp file #461

Merged
merged 3 commits into from
Jun 30, 2020
Merged

feat(Java): use the class name as the name of the temp file #461

merged 3 commits into from
Jun 30, 2020

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Jun 30, 2020

Description

  1. Use the class name as the name of the temp file.
  2. Change the default class name from a to Main.
  3. Add a guide to set the main class name in the compile errors.

Related Issue

This fixes #459.

Motivation and Context

It seems that the main class of Java needs to be public to be submitted to Codeforces:

image

So it will be more convenient if the user can use a public class as the main class.

How Has This Been Tested?

On Arch Linux, with this submission.

@pull-assistant
Copy link

pull-assistant bot commented Jun 30, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     feat: use class name as the name for the temp file for Java

     feat(Java): add a guide to set class name in compile errors

     docs(CHANGELOG): add main class changes for Java

Powered by Pull Assistant. Last update 4b01311 ... 6754cbc. Read the comment docs.

coder3101
coder3101 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will update or open a ticket for removal of this doc from website as well.

@coder3101 coder3101 mentioned this pull request Jun 30, 2020
Closed
@ouuan ouuan merged commit 1ce8572 into master Jun 30, 2020
@ouuan ouuan deleted the java-temp-name branch June 30, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder3101 coder3101 coder3101 approved these changes

@neko-para neko-para neko-para approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the class name as the name of the temporary file of Java
3 participants
@ouuan @coder3101 @neko-para