Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.5.1 #816

Merged
merged 4 commits into from
Sep 25, 2017
Merged

Release/1.5.1 #816

merged 4 commits into from
Sep 25, 2017

Conversation

yk-fujii
Copy link

@yk-fujii yk-fujii commented Sep 25, 2017

Status

DEVELOPMENT

Description

This PR to resolve the 1.5.0 build problem.
In addition, I will raise the version to 1.5.1.

Target issues

Todos

  • Tests
  • Tested with Ubuntu 16.04 and ROS Kinetic
  • Tested with Ubuntu 14.04 and ROS Indigo by Docker

@yk-fujii yk-fujii mentioned this pull request Sep 25, 2017
21 tasks
@amc-nu
Copy link
Member

amc-nu commented Sep 25, 2017

@yk-fujii I checked compilation against Ubuntu 14.04.
However, it's failing on my Ubuntu 16 without GPU setup.
I found the problem in:
https://github.com/CPFL/Autoware/blob/master/ros/src/computing/perception/detection/lib/image/dpm_ttic/CMakeLists.txt#L44

The library is being added in both setups (CPU and GPU), regardless if CUDA was found or not.

@yk-fujii
Copy link
Author

@amc-nu
I could not reproduce the problem in the similar environment.(ubuntu 14.04 without GPU Setup)
It seems that code for GPU is added only when CUDA is found.
https://github.com/CPFL/Autoware/blob/master/ros/src/computing/perception/detection/lib/image/dpm_ttic/CMakeLists.txt#L25

"CUDA_FOUND" is not working?

@amc-nu
Copy link
Member

amc-nu commented Sep 25, 2017

@yk-fujii Found the problem, but we will need to modify later this part.
My setup is Ubuntu 16.04, without GPU, but CUDA installed.
CUDA_FOUND is working correctly, but the linking is made manually instead of using the Vars created by FindCUDA.

@yk-fujii
Copy link
Author

@amc-nu
Is this PR OK? Can you approve?

Why do you need CUDA in an environment without GPU?
The same problem occurs with other nodes such as ssd, yolo and dpm_ocv.
How would you like to fix it?

@amc-nu
Copy link
Member

amc-nu commented Sep 25, 2017

Is this PR OK? Can you approve?

I'm still checking please wait a few more minutes.

Why do you need CUDA in an environment without GPU?

In some cases, I test only compilation and linking of CUDA code.
In other cases, we can run the nodes you mentioned using only CPU support (extremely slow thought)

Copy link
Member

@amc-nu amc-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for the ladybug node still needs to be fixed.

@amc-nu amc-nu merged commit 083ff48 into master Sep 25, 2017
@amc-nu amc-nu deleted the release/1.5.1 branch September 25, 2017 07:25
@yk-fujii
Copy link
Author

@amc-nu
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants