Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [id].tsx #59

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Update [id].tsx #59

merged 2 commits into from
Mar 14, 2022

Conversation

bqi343
Copy link
Member

@bqi343 bqi343 commented Mar 14, 2022

Closes #54

@vercel
Copy link

vercel bot commented Mar 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cpinitiative/ide/84hZFMUKF232cqtn3NNcvqitpBKr
✅ Preview: https://ide-git-download-filename-cpinitiative.vercel.app

Copy link
Member

@thecodingwizard thecodingwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though this might make java files unsubmittable by default. maybe keep java files as Main.java? or use some fancy regex searches to identify the public class name?

@bqi343
Copy link
Member Author

bqi343 commented Mar 14, 2022

if you're submitting through the IDE, this change won't make a difference, will it?

@thecodingwizard
Copy link
Member

yeah it won't

@bqi343
Copy link
Member Author

bqi343 commented Mar 14, 2022

though this might make java files unsubmittable by default. maybe keep java files as Main.java?

true

or use some fancy regex searches to identify the public class name?

maybe in a later PR

@bqi343 bqi343 merged commit 237c362 into master Mar 14, 2022
@thecodingwizard thecodingwizard deleted the download-filename branch June 23, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USACO IDE File Download
2 participants