Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying the completion list should not reset position in the *goals* buffer #8

Closed
JasonGross opened this issue Apr 8, 2015 · 10 comments

Comments

@JasonGross
Copy link

When I have a large goal, and I am scrolled to a particular point in the *goals* buffer, if I type something, and the completion drop-down shows up, the *goals* buffer resets to its default scroll point, much the same way that it does when I execute Show. or C-c C-p. This is annoying, as it means I can't refer to a particular point in the goal while typing things.

@JasonGross
Copy link
Author

This seems to be tied to displaying types in the minibuffer; it shows up for completing theorems (which displays their type in the minibuffer), but not for completing, e.g., Add Parametric Relation.

@cpitclaudel
Copy link
Owner

I think your analysis is right. The problem is probably due to coq-PG reprinting the goal when a new command is issued. I may be able to do something on the company-coq side, but it's really a PG issue.

@cpitclaudel
Copy link
Owner

Could you try this fix when it lands into MELPA? It should fix this bug.

@JasonGross
Copy link
Author

Thanks! Can you ping me when it lands in MELPA?

@cpitclaudel
Copy link
Owner

Sure

@cpitclaudel
Copy link
Owner

Note to self. The fix for this should really be merged into PG; atm company-coq saves the buffer position before calling the prover, and resets the position after calling it, causing disagreeable jitter.

@cpitclaudel
Copy link
Owner

Should be in MELPA now :)

@lczch
Copy link

lczch commented Dec 12, 2015

I have this problem too.
When I want to type something according goals or responds, the point immediately jump to buffer-begin.
It's somewhat annoying :(
Version Information:
company-coq: 20150718.1931
proof-general: latest master branch
Emacs: 24.3.1

@cpitclaudel
Copy link
Owner

Hi @lczch . Can you give me a bit more details? This problem should have been fixed a while back.
What do you mean by "When I want to type something according goals or responds"?

@cpitclaudel
Copy link
Owner

Pushed a cleaner fix to a branch of PG at https://github.com/ProofGeneral/PG/tree/fix-scrolling-buffers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants