This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Call authorization handler before not found handler #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In load_and_authorize_resource, the authorization failure should be handled before resource not found. In addition, if the authorization handler halts the request, the not found handler should not be called, as this may result in an exception if the user tries to subsequently send the request in the not found handler
cpjk
added a commit
that referenced
this pull request
Feb 13, 2016
Call authorization handler before not found handler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In load_and_authorize_resource, authorization failure should be
handled before resource not found.
In addition, if the authorization handler halts the request, the
not found handler should not be called, as this may result in an exception
if the user tries to subsequently send the request in the not found handler