Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[list][*]list[/list] issue #4

Closed
Kulgar opened this issue Feb 22, 2012 · 2 comments
Closed

[list][*]list[/list] issue #4

Kulgar opened this issue Feb 22, 2012 · 2 comments

Comments

@Kulgar
Copy link

Kulgar commented Feb 22, 2012

Hi,

I've tried to write something like this:

   [list]
   [*] List item 1
   [*] List item 2
   [/list]

And this doesn't render the proper html code using BBRuby. [list] [/list] aren't replaced by [ul][/ul] because the regex breaks because of the "list" word in items.

In the regex you have:

     /\[list(:.*)?\]((?:(?!list).)*)\[\/list(:.)?\1?\]/mi

The

    (?!list)

Part is needed, I'm aware of that. If you replace it with:

    (?!\[\/list\])

Everything should work fine, shouldn't it?

@cpjolicoeur
Copy link
Owner

The tests for lists all pass.

I'm happy to take a pull request submission to fix whatever issue you are having. Just make sure to include accompanying tests

@Kulgar
Copy link
Author

Kulgar commented Mar 2, 2012

And solved. :)

71f9124

@Kulgar Kulgar closed this as completed Mar 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants