-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial NB comments #5942
Editorial NB comments #5942
Conversation
a1ae57e
to
2bd0547
Compare
@Dani-Hub: would you care to have a quick look at these editorial fixes? |
@tkoeppe I don't trust my latex capabilities so much to be a confident to make a reliable latex review. I searched for a PDF download under actions, but couldn't find one, maybe I searched at the wrong place, so could you give me a hint, please? |
Great - thanks for your help! |
Ah yes -- thank you, @JohelEGP! |
Because of the vast list I provide a list of explicit confirmations. If you notice a missing NB comment in my list, I have not confirmed it, this allows for validation of the validator: |
List looks right, thank you! (There are additional NB comments on the ballot that have been solved by other means, but these are the 9 ones which required editorial changes.)
That's a mistake in the commit message (a confusion with 3bf3ba0, which I already applied editorially), which came about when I was trying to fix several distinct index-related issues. I will fix the message, well-spotted! |
Thanks. In this case In would confirm my complete list |
Great, thank you very much! |
The correct explanation is that classes `B1` and `D1` do not have default constructors, not that they have deleted default constructors. Fixes NB CA 062 (C++23 CD).
Fixes NB FR 008 (C++23 CD).
This organises the material for <span> and <mdspan> into separate subclauses, rather than having all constituent parts being siblings in the same subclause. Even though we now have some subclauses six levels deep, this seems like an improvement. As a drive-by, this allows us to move a subclause on a non-member span helper function up one level, where it is more appropriate. Fixes NB FR 027 (C++23 CD).
Fixes NB GB 136 (C++23 CD).
Partially fixes NB GB 137 (C++23 CD).
The private, exposition-only data member is not useful in the library index. However, there seems no reason to not show it in the general index, so we move the index entry from the library index to the general index. Partially fixes NB GB 137 (C++23 CD).
Fixes NB US 034 (C++23 CD).
This was an editorial mistake introduced by the transformation of the requirement tables into regular paragraphs. Fixes NB US 100 (C++23 CD).
Our style guide says that "equivalent to <expression>" is the appropriate style for an expression of type `void`, which is the case for `throw`. This avoids the awkward situation of having "equivalent to: `throws;`" appear in the middle of a paragraph without proper terminal punctuation. Fixes NB US 119 (C++23 CD).
Fixes NB US 120 (C++23 CD).
Fixes cplusplus/nbballot#418
Fixes cplusplus/nbballot#424
Fixes cplusplus/nbballot#434
Fixes cplusplus/nbballot#436
Fixes cplusplus/nbballot#478
Fixes cplusplus/nbballot#517
Fixes cplusplus/nbballot#532
Fixes cplusplus/nbballot#533
Also fixes #5894.