Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Scene more robust #7

Open
karnkaul opened this issue Oct 20, 2022 · 0 comments
Open

Make Scene more robust #7

karnkaul opened this issue Oct 20, 2022 · 0 comments
Labels
gltf Involves GLTF code refactoring
Milestone

Comments

@karnkaul
Copy link
Member

karnkaul commented Oct 20, 2022

Currently the construction of a scene is separated from it loading GLTF data and populating its storage. This risks invalid use in between those two points. Either refactor two stage init to a single stage, or ensure the scene is ready to be used after construction / does not attempt to render anything until populated.

AC:

  1. Scene is ready to use after construction
  2. A GLTF source need not be loaded to use a Scene instance
@karnkaul karnkaul added the gltf Involves GLTF code label Oct 20, 2022
@karnkaul karnkaul added this to the Hello collab milestone Oct 20, 2022
@Rinzii Rinzii removed their assignment Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gltf Involves GLTF code refactoring
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants