Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] use non-linear alignment as default #234

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (1bcca23) to head (68d3bc1).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
bidsmreye/prepare_data.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   79.91%   81.64%   +1.73%     
==========================================
  Files          13       16       +3     
  Lines         926     1046     +120     
  Branches      119        0     -119     
==========================================
+ Hits          740      854     +114     
- Misses        144      192      +48     
+ Partials       42        0      -42     
Flag Coverage Δ
tests 81.64% <33.33%> (+1.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau marked this pull request as ready for review August 12, 2024 06:35
Copy link

sourcery-ai bot commented Aug 12, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Remi-Gau Remi-Gau merged commit a4a98f9 into cpp-lln-lab:main Aug 12, 2024
13 of 14 checks passed
@Remi-Gau Remi-Gau deleted the enh/233 branch August 12, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant