Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Boost 1.72.0-p0 #113

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Update Boost 1.72.0-p0 #113

merged 2 commits into from
Jan 6, 2020

Conversation

dan-42
Copy link

@dan-42 dan-42 commented Dec 31, 2019

@dan-42
Copy link
Author

dan-42 commented Dec 31, 2019

PING: @bkotzz @rbsheth

@dan-42
Copy link
Author

dan-42 commented Dec 31, 2019

There is an issue with Boost.System, I'm looking into it

@dan-42
Copy link
Author

dan-42 commented Jan 3, 2020

Current Version of Hunter shows the following Config-files

dan@kay ../_Base/ca19f37/bcfb592/a8d2191/Install % find . | grep Config
./lib/cmake/Boost/BoostConfig.cmake
./lib/cmake/Boost/BoostConfigVersion.cmake
./lib/cmake/Boost-1.71.0/BoostConfigVersion.cmake
dan@kay ../_Base/ca19f37/bcfb592/a8d2191/Install % 

After Update of Boost 1.72.0, we see that an extra Config-file appeared.
And the Boost.System example fails, as it checks if more then one exists.

dan@kay ../_Base/739cd76/bcfb592/9cc5a36/Install % find ./* | grep Config
./lib/cmake/Boost/BoostConfig.cmake
./lib/cmake/Boost/BoostConfigVersion.cmake
./lib/cmake/Boost-1.72.0/BoostConfig.cmake
./lib/cmake/Boost-1.72.0/BoostConfigVersion.cmake

./lib/cmake/Boost/BoostConfig.cmake is the one from hunter
./lib/cmake/Boost-1.72.0/BoostConfig.cmake is provided by boost (Peter Dimov)

So if all test pass now(still waiting!), the is the question do we need to remove the one provided by Boost? Or are we good?

@dan-42
Copy link
Author

dan-42 commented Jan 4, 2020

Copy link
Member

@rbsheth rbsheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose if things are successful, we can just go ahead?

@rbsheth rbsheth merged commit 4b5d226 into cpp-pm:master Jan 6, 2020
@rbsheth
Copy link
Member

rbsheth commented Jan 7, 2020

@noeffn
Copy link

noeffn commented Jan 11, 2020

Getting
Imported target "Boost::boost" includes non-existent path

"/root/.hunter/_Base/503b149/b014198/cbc5d16/Source"

in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include:

  • The path was deleted, renamed, or moved to another location.

  • An install or uninstall procedure did not complete successfully.

  • The installation package was faulty and references files it does not
    provide.

@dan-42
Copy link
Author

dan-42 commented Jan 12, 2020

@michaeldkroener I created #133 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants