Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isolate #401

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix isolate #401

merged 1 commit into from
Dec 6, 2022

Conversation

joke2k
Copy link

@joke2k joke2k commented Dec 6, 2022

getLinks() now returns the same data structure as getSites() and can be used together to find a site to isolate (the ->where('site', $site) didn't find links)

PhpFpmTest::test_install_configuration_replaces_user_and_sock_in_config_file doesn't pass but I think is not related to my edits.

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Adesin-fr Adesin-fr merged commit 3222f48 into cpriego:master Dec 6, 2022
@Adesin-fr
Copy link
Collaborator

Can you try the master branch ?
I've merged your fix, and added another one (the isolated version was not correctly "saved" in nginx conf file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants