Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: '<' not supported between instances of 'NoneType' and 'NoneType' #531

Closed
g4s8 opened this issue Jul 20, 2020 · 7 comments
Closed

Comments

@g4s8
Copy link

g4s8 commented Jul 20, 2020

After updating to 1.2.3 version aibolit starting to fail for recommend command for github.com/artipie/artipie repository with error:

$ aibolit recommend --folder src/main/java --format=long --full 

Traceback (most recent call last):
  File "/home/g4s8/.local/lib64/python3.6/site-packages/aibolit/__main__.py", line 788, in main
    exit_code = run_parse_args(commands)
  File "/home/g4s8/.local/lib64/python3.6/site-packages/aibolit/__main__.py", line 102, in run_parse_args
    return commands_dict[args.command]()
  File "/home/g4s8/.local/lib64/python3.6/site-packages/aibolit/__main__.py", line 785, in <lambda>
    'recommend': lambda: check(),
  File "/home/g4s8/.local/lib64/python3.6/site-packages/aibolit/__main__.py", line 682, in check
    new_results = format_converter_for_pattern(results, 'code_line')
  File "/home/g4s8/.local/lib64/python3.6/site-packages/aibolit/__main__.py", line 729, in format_converter_for_pattern
    } for line in sorted(x['code_lines'])] for x in items
  File "/home/g4s8/.local/lib64/python3.6/site-packages/aibolit/__main__.py", line 729, in <listcomp>
    } for line in sorted(x['code_lines'])] for x in items
TypeError: '<' not supported between instances of 'NoneType' and 'NoneType'
@acheshkov
Copy link
Member

@lyriccoder, can we add an integration test to avoid such things in the future?

@acheshkov
Copy link
Member

@rultor release, tag=1.2.4

@rultor
Copy link
Collaborator

rultor commented Jul 20, 2020

@rultor release, tag=1.2.4

@acheshkov OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jul 20, 2020

@rultor release, tag=1.2.4

@acheshkov Done! FYI, the full log is here (took me 16min)

@g4s8
Copy link
Author

g4s8 commented Jul 20, 2020

@acheshkov @lyriccoder it can be reproduced with this script in docker:

$ docker run --rm -it python:latest /bin/bash
# pip install --upgrade pip
# pip install aibolit
# mkdir /repo && cd /repo
# git clone https://github.com/artipie/artipie.git
# cd artipie
# aibolit recommend --folder src/main/java --format=long --full 

@lyriccoder
Copy link
Member

@acheshkov can we close it?

@g4s8
Copy link
Author

g4s8 commented Jul 23, 2020

@lyriccoder it's working now, thanks

@g4s8 g4s8 closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants